soft delete logic fixing tests for BigQuery #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
previously approved these changes
Dec 20, 2023
serprex
reviewed
Dec 21, 2023
serprex
reviewed
Dec 21, 2023
|
heavycrystal
changed the title
|
I think the BQ tests are becoming slower due to metadata table advisory lock contention. This is needed because BQ doesn't allow concurrent updates. Changed the lock acquisition logic slightly. |
serprex
reviewed
Dec 22, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
serprex
approved these changes
Dec 25, 2023
serprex
reviewed
Dec 26, 2023
| @@ -452,7 +452,8 @@ func (c *BigQueryConnector) getTableNametoUnchangedCols(flowJobName string, sync | |||
| // Prepare the query to retrieve distinct tables in that batch | |||
| query := fmt.Sprintf(`SELECT _peerdb_destination_table_name, | |||
| array_agg(DISTINCT _peerdb_unchanged_toast_columns) as unchanged_toast_columns FROM %s.%s | |||
| WHERE _peerdb_batch_id > %d and _peerdb_batch_id <= %d GROUP BY _peerdb_destination_table_name`, | |||
| WHERE _peerdb_batch_id > %d AND _peerdb_batch_id <= %d AND _peerdb_record_type != 2 | |||
There was a problem hiding this comment.
Include in PR description what _peerdb_record_type != 2 achieves
Co-authored-by: Philip Dubé <[email protected]>
heavycrystal
force-pushed
the
soft-delete-tests-bq
branch
from
a22be94 to
c5ca198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.